Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social | Enable connections management for WPCOM sites #41019

Draft
wants to merge 5 commits into
base: social/unified-connections-management
Choose a base branch
from
Draft

Social | Enable connections management for WPCOM sites #41019

wants to merge 5 commits into from
+17 −7

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Jan 14, 2025 •
edited
Loading

Related to 168243-ghe-Automattic/wpcom

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Use the below matrix to conduct these tests
  • Apply 168243-ghe-Automattic/wpcom to your sandbox
  • Apply this branch to your sandbox while being on the above wpcom branch, instead of on trunk
  • Point the public API to your sandbox
  • Test the following on Jetpack, Simple and Atomic sites
  • Point the site to your sandbox
  • Goto connections management on Jetpack and Social admin page
  • Confirm that the connections load fine
  • Confirm the same in the editor
  • Add/remove a connection
  • Confirm that it works as expected
  • Mark/unmark a connection as shared
  • Confirm that it works fine
  • Reload the page
  • Confirm that the changes are retained.
  • Test the above as an author account
  • Verify that you are able to see the "Disconnect" button
  • Verify that the author is not able see the "Disconnect" button for shared connections
  • Break a few connections
    • For Mastodon, remove Jetpack here.
    • For Facebook, remove Jetpack here.
  • Verify that broken connections are marked as such in the connections manage and in the editor notices
Jetpack plugin Social Plugin Block editor ✅ Classic editor ✅
Jetpack and Atomic sites
This branch This branch
This branch Latest release
Latest release This branch
This branch v4.x.x
v13.x.x This branch
Simple sites
Block editor ✅ Classic editor ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for February 4, 2025 (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 14, 2025
@manzoorwanijk manzoorwanijk added [Type] Task and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 14, 2025
@manzoorwanijk manzoorwanijk self-assigned this Jan 14, 2025
@manzoorwanijk manzoorwanijk force-pushed the update/social/enable-connections-management-for-wpcom branch from b0b31cd to e221b4f Compare January 14, 2025 12:10
@manzoorwanijk manzoorwanijk changed the base branch from trunk to add/social/rest-crud-endpoints January 14, 2025 12:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social/enable-connections-management-for-wpcom branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/social/enable-connections-management-for-wpcom

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests labels Jan 14, 2025
Base automatically changed from add/social/rest-crud-endpoints to social/unified-connections-management January 15, 2025 04:42
@manzoorwanijk manzoorwanijk force-pushed the update/social/enable-connections-management-for-wpcom branch from 2b94898 to 1904ea3 Compare January 15, 2025 04:47
@manzoorwanijk manzoorwanijk requested a review from a team January 15, 2025 04:47
@manzoorwanijk manzoorwanijk mentioned this pull request Jan 15, 2025
Open
3 tasks
@manzoorwanijk manzoorwanijk force-pushed the update/social/enable-connections-management-for-wpcom branch 2 times, most recently from 0aa2bdb to c0bc061 Compare January 15, 2025 13:17
@pablinos
Copy link
Contributor

With this branch on Jetpack and the latest release of Social, and the changes sandboxed, I seem to be able to get an error when trying to connect to LinkedIn

CleanShot 2025-01-15 at 22 55 39@2x

I managed to fix it by swapping to around plugin versions but got it a second time by swapping back to this combination, so I think there might be something to it.

@manzoorwanijk
Copy link
Member Author

With this branch on Jetpack and the latest release of Social, and the changes sandboxed, I seem to be able to get an error when trying to connect to LinkedIn

I set up a JN site with exactly the same configuration, but it works fine.

  • Jetpack on PR branch
  • Social on latest release - v6
  • Changes sandboxed (You can see the top bar in the screenshot)

image

@manzoorwanijk manzoorwanijk force-pushed the update/social/enable-connections-management-for-wpcom branch from c0bc061 to a63cdd7 Compare January 16, 2025 09:13
@manzoorwanijk manzoorwanijk force-pushed the update/social/enable-connections-management-for-wpcom branch from a63cdd7 to 059a69d Compare January 16, 2025 11:57
@pablinos
Copy link
Contributor

It must have been something wrong with the JN site. I can still get the error on there but I can get it working on other test sites.

I've just noticed that we're rendering profile images when they're missing. We used to have something to prevent that

CleanShot 2025-01-16 at 17 23 43@2x

It might not be related to this branch, so we could handle it in a follow up, but it would nice not to have the problem as we launch it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@manzoorwanijk manzoorwanijk

Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [JS Package] Publicize Components [Package] Publicize [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Wpcomsh RNA [Status] In Progress [Tests] Includes Tests [Type] Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manzoorwanijk @pablinos